Re: [RFC] remove IDESCSI_SG_TRANSFORM (compile fix)

Mike Anderson (andmike@us.ibm.com)
Fri, 29 Nov 2002 16:44:35 -0800


Christoph Hellwig [hch@lst.de] wrote:
> In the current 2.5 scsi-misc tree Scsi_Device_Template.tag is gone.
>
> ide-scsi is still using it in should_transform() to decide whether
> to test IDESCSI_SG_TRANSFORM or IDESCSI_TRANSFORM.
>
> The obvious compile fix is to just kill that check, which makes
> IDESCSI_SG_TRANSFORM superflous. Of course the question remains
> what the actual point of IDESCSI_SG_TRANSFORM was and if we still
> need it.

Thanks for catching this Christoph I thought the only use was inside
SCSI. I could make a patch to scsi-misc to add tag back in. Another
option if it is still needed is to switch to "->name == "generic").

Though I have not used this interface I thought if one was using an sg
device to a ide-scsi device and the flag was set that sg commands that
where not 100% the same as ATAP commands where translated.

-andmike

--
Michael Anderson
andmike@us.ibm.com

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/