Is this patch okay?

Maciej Soltysiak (solt@dns.toxicfilms.tv)
Wed, 4 Dec 2002 21:46:54 +0100 (CET)


Hello,

i downloaded 2.5.50, started compiling it, and it bailed out with an error
in drivers/pci/quirks.c, that sis_apic_bug is not defined.
I did a quick grep around the source and found a file to include.

Basically, this is what i did.

*** linux-2.5.50.old/drivers/pci/quirks.c Wed Nov 27 23:35:48 2002
--- linux-2.5.50/drivers/pci/quirks.c Wed Dec 4 21:40:44 2002
***************
*** 18,23 ****
--- 18,24 ----
#include <linux/pci.h>
#include <linux/init.h>
#include <linux/delay.h>
+ #include <asm/io_apic.h>

#undef DEBUG

Is it okay to include it like that?
Or should it be fixed some other way? I am just getting around the kernel,
though the kernel has one my small patch, i am definitelly no guru.

I guess that some people have already noticed that, so if this has been
resolved, please ignore the patch.
I would appreciate any answer anyway.

Best Regards,
Maciej Soltysiak

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/