Re: [PATCH] aacraid 2.5

Peter Chubb (peter@chubb.wattle.id.au)
Tue, 10 Dec 2002 09:02:18 +1100


>>>>> "Mark" == Mark Haverkamp <markh@osdl.org> writes:

Mark> On Fri, 2002-12-06 at 16:30, Christoph Hellwig wrote:
>> On Fri, Dec 06, 2002 at 07:45:42AM -0800, Mark Haverkamp wrote: >
>> +/** > + * Convert capacity to cylinders > + * accounting for the
>> fact capacity could be a 64 bit value > + * > + */ > +static inline
>> u32 cap_to_cyls(sector_t capacity, u32 divisor) > +{ > +#ifdef
>> CONFIG_LBD > + do_div(capacity, divisor); > +#else > + capacity /=
>> divisor; > +#endif > + return (u32) capacity; > +}
>>
>> Please use sector_div() instead. It exists for a reason.

Mark> Thanks for finding this. I have enclosed a change using your
Mark> suggestion.

sector_div(a, b) is just like do_div(a, b) -- it returns the
remainder, and sets a to a/b which is not reflected in your patch...

--
Dr Peter Chubb				    peterc@gelato.unsw.edu.au
You are lost in a maze of BitKeeper repositories, all almost the same.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/