Re: [BK][PATCH] ReiserFS CPU and memory bandwidth efficient large writes

Andrew Morton (akpm@digeo.com)
Sat, 14 Dec 2002 10:42:38 -0800


Oleg Drokin wrote:
>
> Hello!
>
> On Fri, Dec 13, 2002 at 01:40:42PM -0800, Andrew Morton wrote:
>
> > This seems wrong. This could be a newly-allocated pagecache page. It is not
> > yet fully uptodate. If (say) the subsequent copy_from_user gets a fault then
> > it appears that this now-uptodate pagecache page will leak uninitialised stuff?
>
> Ok, after all I think we do not need this uptodate stuff at all.

Well that certainly simplifies things.

> Find below the patch that address all the issues you've brought.
> It is on top of previous one.
> Do you think it is ok now?

I addresses the things I noticed and raised, thanks. Except for the
stack-space use. People are waving around 4k-stack patches, and we
do need to be careful there.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/