Re: 6/19

Tomas Szepe (szepe@pinerecords.com)
Mon, 16 Dec 2002 11:35:58 +0100


> + /*
> + * chunk_size is a power of two
> + */
> + if (!chunk_size || (chunk_size & (chunk_size - 1))) {
> + ti->error = "dm-stripe: Invalid chunk size";
> + return -EINVAL;
> + }

Is 1 a valid chunksize then? [It certainly is not a power of two. ;)]
If not, you need

if (chink_size < 2 || (chunk_size & (chunk_size - 1))) { ... }

-- 
Tomas Szepe <szepe@pinerecords.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/