Re: [PATCH] move LOG_BUF_SIZE to header file

[Randy.Dunlap]

On Tue, 17 Dec 2002, Christoph Hellwig wrote:

| On Mon, Dec 16, 2002 at 10:11:42PM -0800, Randy.Dunlap wrote:
| > --- ./arch/i386/Kconfig%LOGBUF	Sun Dec 15 18:07:47 2002
| > +++ ./arch/i386/Kconfig	Sun Dec 15 20:45:09 2002
| > @@ -1573,6 +1573,43 @@
| >  	  If you don't debug the kernel, you can say N, but we may not be able
| >  	  to solve problems without frame pointers.
| >
| > +choice
| > +	prompt "Kernel log buffer size"
| > +	default LOG_BUF_128KB if ARCH_S390
| > +	default LOG_BUF_64KB if X86_NUMAQ || IA64
| > +	default LOG_BUF_32KB if SMP
| > +	default LOG_BUF_16KB
|
| yuck.  Why don't you just add and integer LOG_BUG_SHIFT symbol that can
| be freely choosen?

I'll think about that, see how it works out.
LOG_BUF_SHIFT seems reasonable (for developers, not for users), but I
think that there should be some decent defaults also.

-- 
~Randy