Re: [PATCH][2.5] fix for_each_cpu compilation on UP

James Bottomley (James.Bottomley@SteelEye.com)
Fri, 17 Jan 2003 10:03:55 -0500


zwane@holomorphy.com said:
> This adds a definition for for_each_cpu when !CONFIG_SMP
> Please apply

Could you elaborate on the purpose of this a bit? for_each_cpu() is only used
by the voyager subarch on x86 to traverse sparse CPU bitmaps efficiently in
critical path code. It has no other use in x86 SMP because all other
subarch's tend to compact the CPU bitmap much more.

If there are other uses for the construct, it should probably be put in bitops
and become for_each_bit(i, mask)

James

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/