Re: [PATCH][RESEND] linux-2.5.58_timer-tsc-cleanup_A0

Rusty Russell (rusty@rustcorp.com.au)
Sat, 18 Jan 2003 12:48:14 +1100

In message <1042676113.1515.129.camel@w-jstultz2.beaverton.ibm.com> you write:
> Linus, All,
> This patch cleans up the timer_tsc code, removing the unused use_tsc
> variable and making fast_gettimeoffset_quotient static.

But use_tsc is still used:

static int
time_cpufreq_notifier(struct notifier_block *nb, unsigned long val,
void *data)
{

....

#ifndef CONFIG_SMP
if (use_tsc) {
fast_gettimeoffset_quotient = cpufreq_scale(fast_gettimeoffset_ref, freq->new, ref_freq);
cpu_khz = cpufreq_scale(cpu_khz_ref, ref_freq, freq->new);
}
#endif

And almost any patch to the x86 boot code is too convoluted to be
"trivial" IMHO.

Sorry,
Rusty.

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/