[PATCH?] slab.c

Andries.Brouwer@cwi.nl
Mon, 27 Jan 2003 00:14:32 +0100 (MET)


In slab.c the routine check_poison_obj() is called.
That routine does nothing except return 0 or 1.
Thus it looks like the present call in slab_destroy()
is meaningless. Perhaps something like this was meant?

--- slab.c~ Sat Jan 18 23:54:30 2003
+++ slab.c Mon Jan 27 00:05:47 2003
@@ -796,7 +796,8 @@
void *objp = slabp->s_mem + cachep->objsize * i;

if (cachep->flags & SLAB_POISON)
- check_poison_obj(cachep, objp);
+ if (check_poison_obj(cachep, objp))
+ BUG();

if (cachep->flags & SLAB_RED_ZONE) {
if (*((unsigned long*)(objp)) != RED_INACTIVE)

A BUG() was lost in patch 2.5.45.

Andries
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/