Re: [PATCH] IDE: Do not call bh_phys() on buffers with invalid

Benjamin Herrenschmidt (benh@kernel.crashing.org)
29 Jan 2003 15:57:46 +0100

Hi, I just spotted this in the patch (but the code itself have been
there since 2.4.20-pre2).

> - if (((unsigned long) bh->b_data) < PAGE_SIZE)
> + if ((unsigned long) bh->b_data < PAGE_SIZE)

Didn't you meant PAGE_OFFSET and not PAGE_SIZE here ? I fail to see why
it would make any sense to compare a virtual address to PAGE_SIZE ;)

Ben.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/