Re: BUG: [2.4.18+] IDE Race Condition

Ross Biro (rossb@google.com)
Thu, 30 Jan 2003 08:58:50 -0800


Alan Cox wrote:

>>st should be replaced with
>>if (!masked_irq || hwif->irq != masked_irq)
>>in two places.
>>
>>
>
>Which would also shorten to if (hwif->irq != masked_irq) it seems
>
>
>
With the assumption that hwif->irq != 0 which is implicit now. Perhaps
we should make the assumption explicit,

if (unlikely(hwif->irq == 0)) {
BUG();
}
if (hwif->irq != masked_irq) ....

Ross

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/