Re: [BUG] vmalloc, kmalloc - 2.4.x

Arjan van de Ven (arjanv@redhat.com)
03 Feb 2003 16:19:47 +0100


This is a MIME-formatted message. If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_courier-801-1044285647-0001-2
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Mon, 2003-02-03 at 16:13, Grzegorz Jaskiewicz wrote:
> few days ago i started to port driver for our hardware in company from
> windows to linux. It is simple ISA card, which gives me interrupt each
> 8ms. So i can check it state and latch some sort of watchdog on it -
> saying that i am still running (just for security, if system hangs card
> is blocking all inputs/outputs).=20

> #include <linux/modversions.h>

don't do that. ever.

> #ifdef CONFIG_KMOD
> #include <linux/kmod.h>
> #endif

bullshit ifdef's (and the surrounding code has a whole bunch too

btw you do know you can't do vmalloc (or vfree) from interrupt context ?
And that every vmalloc eats at minimum 8Kb of virtual memory space? Of
which you can't count on having more than 64Mb on x86 ?

--=_courier-801-1044285647-0001-2
Content-Type: application/pgp-signature; name="signature.asc"
Content-Transfer-Encoding: 7bit
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQA+PoiTxULwo51rQBIRAmDwAJ48trT0JIW+49vpvMNFhKDw6Ds4TQCfQ+hz
Y3N5ISTb6DtTh532l1B+SwI=
=bhOg
-----END PGP SIGNATURE-----

--=_courier-801-1044285647-0001-2--