module removal race possible in nf_sockopt?

Bart De Schuymer (bdschuym@pandora.be)
Tue, 4 Feb 2003 17:47:25 +0100


Hello Rusty,

Isn't there a module race possible with the netfilter function nf_sockopt
(net/core/netfilter.c)? This function calls the sockopt function of a
registered netfilter module, like iptables. F.e. the function do_ipt_set_ctl
in ip_tables.c could be called.
What if the iptables module is being unloaded on one cpu, while another cpu
just called do_ipt_set_ctl?
I think there needs to be a try_module_get and module_put in the nf_sockopt
function to handle this. What do you think?

-- 
cheers,
Bart

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/