Re: [PATCH - 2.5.60] JFS no longer compiles with gcc 2.95

Dave Kleikamp (shaggy@austin.ibm.com)
Wed, 12 Feb 2003 09:42:01 -0600


On Wednesday 12 February 2003 09:04, Adrian Bunk wrote:

> Ah, then it's a well-known 2.95 parser bug (sorry for not looking
> better at it when sending my initial report). The following
> alternative patch is sufficient to fix the compilation with 2.95
> (it's your choice which of the two patches you prefer):
>
> --- linux-2.5.60-full/fs/jfs/jfs_debug.h.old 2003-02-12
> 15:59:14.000000000 +0100 +++
> linux-2.5.60-full/fs/jfs/jfs_debug.h 2003-02-12 15:59:35.000000000
> +0100 @@ -90,7 +90,7 @@
> #define jfs_err(fmt, arg...) do { \
> if (jfsloglevel >= JFS_LOGLEVEL_ERR) \
> printk(KERN_ERR "%s:%d " fmt "\n", \
> - __FILE__, __LINE__, ## arg); \
> + __FILE__ , __LINE__ , ## arg); \
> } while (0)
>
> /*

Interesting that the assert() macro in the same file is very similar,
but apparently doesn't have the same problem. Do you know if it's tied
to the ## operator? I'm not emotionally attached to __FILE__ and
__LINE__, so I'll just go with removing them, unless anyone wants to
change my mind.

Thanks,
Shaggy

-- 
David Kleikamp
IBM Linux Technology Center

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/