Re: [PATCH 2.5.60 2/9] Update parport class driver to new module loader API.

[Bob Miller]

On Sat, Feb 15, 2003 at 11:16:42AM +0000, Christoph Hellwig wrote:
> On Fri, Feb 14, 2003 at 03:45:57PM -0800, Bob Miller wrote:
> > -	void (*inc_use_count)(void);
> > +	int (*inc_use_count)(void);
> >  	void (*dec_use_count)(void);
> 
> This is broken.  You need
> 
> 	struct module *owner;
> 
> here and use try_module_et/module_put before calling into the module.

Christoph,

Thanks for taking the time to review this.  Your comments are similar
to Russell King's.  I'll fix this and then re-submit.  Thanks again.

-- 
Bob Miller					Email: [e-mail]
Open Source Development Lab			Phone: [phone] Ext. 17