Re: PATCH: clean up the IDE iops, add ones for a dead iface

Linus Torvalds (torvalds@transmeta.com)
Wed, 19 Feb 2003 08:56:37 -0800 (PST)


On 19 Feb 2003, Benjamin Herrenschmidt wrote:
>
> Hrm... I tend to agree with Russell here... 0x7f is the "safe" value
> for IDE. IDE controllers with nothing wired shall have a pull down
> on D7. The reason is simple: busy loops in the IDE code waiting for
> BSY to go down.

But that's a BUG.

We've seen that before: try unplugging a PCMCIA IDE card unexpectedly.

Guess what? It will start returning 0xff. And the machine dies, because
the PCMCIA interrupt happened due to the removal event will also be shared
by the IDE driver, so the IDE driver will react badly even before anybody
has had a chance to tell it that the hardware no longer exists.

So if you have code that doesn't work with 0xff, then that code is already
a-priori buggy. And getting it fixed would be a damn good idea.

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/