Re: [PATCH][ATM] cli() for net/atm/lec.c

[Christoph Hellwig]

>  extern void (*br_fdb_put_hook)(struct net_bridge_fdb_entry *ent);
> +static spinlock_t lec_arp_spinlock = SPIN_LOCK_UNLOCKED;
> +static unsigned long lec_arp_flags;
>  
> +#define LEC_ARP_LOCK()   spin_lock_irqsave(&lec_arp_spinlock, lec_arp_flags);
> +#define LEC_ARP_UNLOCK() spin_unlock_irqrestore(&lec_arp_spinlock, lec_arp_flags);

I don't think this is a good idea - use the spin_lock calls directly and
always use flags on the stack.

>          dev->get_stats = lec_get_stats;
>          dev->set_multicast_list = NULL;
>          dev->do_ioctl  = NULL;
> +	spin_lock_init(&lec_arp_spinlock);

not needed - you already initialized it at compiletime