Re: [PATCH][2.5] replace flush_map() in arch/i386/mm/pageattr.c w ith flush_tlb_all()

Dave Jones (davej@codemonkey.org.uk)
Fri, 21 Feb 2003 15:10:32 +0000

On Fri, Feb 21, 2003 at 02:52:38PM +0000, Hugh Dickins wrote:

> Of course that's much much better. But I think rather better as
> static inline void on_each_cpu(void (*func) (void *info), void *info)
> passing info to func instead of assuming NULL. inline? maybe.

Sounds good to me. As for inline - This thing will be generating lots
of IPIs on SMP, so its hardly going to be performance critical, so
we could leave it out of line IMO.

Dave

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/