Doesn't compile (curtask undeclared) and doesn't work (SIGCHLD is
still SIG_IGN causing system() to fail). The problem is that
kernel/workqueue.c:worker_thread() [which is what runs modprobe now]
sets SIGCHLD to SIG_IGN, and your patch doesn't unbreak that.
The patch below, applied on top of your patch, makes it work for me.
/Mikael
--- linux-2.5.62/kernel/kmod.c.~2~ 2003-02-24 12:39:01.000000000 +0100
+++ linux-2.5.62/kernel/kmod.c 2003-02-24 13:27:51.000000000 +0100
@@ -150,10 +150,12 @@
static int ____call_usermodehelper(void *data)
{
struct subprocess_info *sub_info = data;
+ struct task_struct *curtask = current;
int retval;
/* Unblock all signals. */
flush_signals(curtask);
+ curtask->sighand->action[SIGCHLD-1].sa.sa_handler = SIG_DFL;
flush_signal_handlers(curtask);
spin_lock_irq(&curtask->sighand->siglock);
sigemptyset(&curtask->blocked);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/