RE: [ACPI] [PATCH] 1/3 ACPI resource handling

[Moore, Robert]

Yes, as long as the code is used more than once (which it appears to be),
then of course it should be procedurized.
Bob

-----Original Message-----
From: Pavel Machek [mailto:[e-mail]] 
Sent: Sunday, February 23, 2003 2:55 PM
To: Moore, Robert
Cc: 'Bjorn Helgaas'; Grover, Andrew; Walz, Michael; [e-mail];
[e-mail]; [e-mail]
Subject: Re: [ACPI] [PATCH] 1/3 ACPI resource handling

Hi!

> 1) This seems like a good idea to simplify the parsing of the resource
lists
> 
> 2) I'm not convinced that this buys a whole lot -- it just hides the code
> behind a macro (something that's not generally liked in the Linux world.)
> Would this procedure be called from more than one place?

Well, reducing code duplication *is* liked in Linux world. Use inline
function instead of macro if possible, through.
	
Pavel
-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]