Re: [PATCH][2.5] fix preempt-issues with smp_call_function()

Thomas Schlichter (schlicht@uni-mannheim.de)
Wed, 26 Feb 2003 11:14:30 +0100


--Boundary-02=_MOJX+xt+Qub5Wlt
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Description: signed data
Content-Disposition: inline

Dave Jones <davej@codemonkey.org.uk> wrote:
> Just one comment. You moved quite a few of the preempt_disable/enable
> pairs outside of the CONFIG_SMP checks. The issue we're working against
> here is to try and prevent preemption and ending up on a different CPU.
> As this cannot happen if CONFIG_SMP=n, I don't see why you've done this.

Andrew Morton wrote:
> Just in two places.
[snip]

Yes, thanks for delivering this better patch!
My approach wanted just to be the most simple possibility... ;-)

Thomas
--Boundary-02=_MOJX+xt+Qub5Wlt
Content-Type: application/pgp-signature
Content-Description: signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQA+XJOMYAiN+WRIZzQRAhekAJ9KkPAji4SFebt2ahvYipLcNKcvGwCgqkh4
BtOSc98n7n+Ev7u3aoBrUZ4=
=55UI
-----END PGP SIGNATURE-----

--Boundary-02=_MOJX+xt+Qub5Wlt--

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/