> Ok, can people agree on this simplified version of Mikaels patch, which
> doesn't BUG_ON(), and doesn't reset 'boot_cpu_physical_apicid'
> unnecessarily..
>
> Does this work for people?
Works for me, but I'm curious if it works for Rusty. We're still not sure
if he's hitting the same bug... but I guess it's rather early morning in
.au. :-)
Oh, and 2.4 needs the same fix -- and if Mikael's original BUG_ON() is
undesirable then we should probably also remove this code from 2.4's
apic.c:setup_local_APIC()
if (!clustered_apic_mode &&
!test_bit(GET_APIC_ID(apic_read(APIC_ID)), &phys_cpu_present_map))
BUG();
because it's essentially the same test as the BUG_ON(), at least for the
UP case.
Thanks,
Ion
--
It is better to keep your mouth shut and be thought a fool,
than to open it and remove all doubt.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/