Re: [UPDATED PATCH] Re: 2.5.63 - if/ifdef janitor work - actual bug found..

Bill Davidsen (davidsen@tmr.com)
Fri, 28 Feb 2003 09:17:53 -0500 (EST)


This is a MIME-formatted message. If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_courier-9885-1046442144-0001-2
Content-Type: TEXT/PLAIN; CHARSET=us-ascii
Content-ID: <14388.1046379775.1@turing-police.cc.vt.edu>

On Thu, 27 Feb 2003 Valdis.Kletnieks@vt.edu wrote:

> On Thu, 27 Feb 2003 14:42:50 CST, Thomas Molina said:
>
> > Why couldn't it be MAY_OWNER_OVERRIDE??? There are occurrences of
> > MAY_OWNER_OVERRIDE
>
> Yes, but then the logic becomes:
>
> #if (a | b | MAY_OWNER_OVERRIDE) & (c | d | MAY_OWNER_OVERRIDE)
> #error ....
> #endif
>
> so it will *alway* error out. Tried it, it #errored, I looked at it
> more closely. The logic there is that it wants to have the two sets
> (SATTR, TRUNC, LOCK, LOCAL_ACCESS) and (READ, WRITE, EXEC, OVERRIDE)
> as disjoint sets of bits.

Thanks for that clarification, I had kept the original message to ask the
same question. Actually, while you are fixing this, how about putting in a
comment line saying what you just told us? It makes reading the code much
easier!

-- 
bill davidsen <davidsen@tmr.com>
  CTO, TMR Associates, Inc
Doing interesting things with little computers since 1979.

--=_courier-9885-1046442144-0001-2 Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit Content-ID: <Pine.LNX.3.96.1030228091558.25875E@gatekeeper.tmr.com> Content-Description:

-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) Comment: Exmh version 2.5 07/13/2001

iD8DBQE+Xnz/cC3lWbTT17ARAnXbAKDhV3cXEo/cZYe02dkK31nfVmT9OQCggTJE ZhHgoiSzkZE+S4DNEQSKSWI= =UM2J -----END PGP SIGNATURE-----

--=_courier-9885-1046442144-0001-2--