[PATCH] 7/7 Fix error bounds checking for NUMA-Q

Martin J. Bligh (mbligh@aracnet.com)
Fri, 28 Feb 2003 13:34:20 -0800


Patch from Dave Hansen.

Fix simpile bounding error found by some Stanford-checker type thing
to use the proper MAX_MP_BUSSES define instead of a constant.

diff -urpN -X /home/fletch/.diff.exclude 015-notsc/arch/i386/pci/numa.c 016-numa_pci_fix/arch/i386/pci/numa.c
--- 015-notsc/arch/i386/pci/numa.c Thu Jan 9 19:15:56 2003
+++ 016-numa_pci_fix/arch/i386/pci/numa.c Fri Feb 28 08:05:36 2003
@@ -17,7 +17,7 @@ static int __pci_conf1_mq_read (int seg,
{
unsigned long flags;

- if (!value || (bus > 255) || (dev > 31) || (fn > 7) || (reg > 255))
+ if (!value || (bus > MAX_MP_BUSSES) || (dev > 31) || (fn > 7) || (reg > 255))
return -EINVAL;

spin_lock_irqsave(&pci_config_lock, flags);
@@ -45,7 +45,7 @@ static int __pci_conf1_mq_write (int seg
{
unsigned long flags;

- if ((bus > 255) || (dev > 31) || (fn > 7) || (reg > 255))
+ if ((bus > MAX_MP_BUSSES) || (dev > 31) || (fn > 7) || (reg > 255))
return -EINVAL;

spin_lock_irqsave(&pci_config_lock, flags);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/