Re: share COMPATIBLE_IOCTL()s across architectures

Arnd Bergmann (arnd@bergmann-dalldorf.de)
Thu, 20 Mar 2003 02:35:30 +0100


Andi Kleen wrote:

> Shouldn't you put the include files needed for all that in there too?
>
> Otherwise you have another ugly list to duplicate. The includes
> cannot be put inside the ioctl list, because in some extreme
> case they can generate code (e.g. when gcc decides to ignore inline
> again and emits functions for includes)

Why not simply move the common COMPATIBLE_IOCTLs and includes into
kernel/compat_ioctl.c or similar? That would IMHO be cleaner and
it does not need more preprocessing hacks.
There can still be a second init_sys32_ioctl() copy to handle the arch
specific list with additional translations.

Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/