Re: [PATCH] s390 update (4/9): common i/o layer update.

[Christoph Hellwig]

On Wed, Mar 26, 2003 at 04:10:16PM +0100, Martin Schwidefsky wrote:
> +	typeof (chsc_area_ssd.response_block)
> +		*ssd_res = &chsc_area_ssd.response_block;

Yikes!  Please use the actual type here instead of typeof()

> +	if (sch->lpm == 0)
> +		return -ENODEV;
> +	else
> +		return -EACCES;

I'd write this as return (sch->lpm ? -EACCES : -ENODEV), but maybe I'm
just too picky..

> -	sch = kmalloc (sizeof (*sch), GFP_DMA);
> +	sch = kmalloc (sizeof (*sch), GFP_KERNEL | GFP_DMA);

What about using GFP_KERNEL | __GFP_DMA instead?  This makes it
more clear that it's just a qualifier.