--=_courier-20986-1048721909-0001-2
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Wed, 2003-03-26 at 22:29, Greg KH wrote:
> Some of the nasty casts should be fixed up though. Stuff like:
>=20
> > + ERROR7:
> > + if (!is_isa)
> > + i2c_detach_client(&
> > + (((struct w83781d_data
> > + *) (i2c_get_clientdata(new_client)))->
> > + lm75[1]));
> > + ERROR6:
> > + if (!is_isa)
> > + i2c_detach_client(&
> > + (((struct w83781d_data
> > + *) (i2c_get_clientdata(new_client)))->
> > + lm75[0]));
> > + ERROR5:
> > + if (!is_isa)
> > + kfree(((struct w83781d_data *) (i2c_get_clientdata(new_client)))->
> > + lm75);
>=20
> Is just obnoxious :)
>=20
Quick question .... With sysfs, is it not needed to call
i2c_detach_client ? I am asking this as it seems from patches
that you remove all these calls ...
Regards,
--=20
Martin Schlemmer
--=_courier-20986-1048721909-0001-2
Content-Type: application/pgp-signature; name="signature.asc"
Content-Transfer-Encoding: 7bit
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQA+gjkHqburzKaJYLYRAsjqAKCbZLehBMLJ6laG+R1XYZ1wSTKG8QCfUE9q
ewZ4diZ4WO5k2gZGS1ITV6c=
=YEr3
-----END PGP SIGNATURE-----
--=_courier-20986-1048721909-0001-2--