Re: [TRIVIAL] Cleanup in fs/devpts/inode.c
Felipe Alfaro Solana (felipe_alfaro@linuxmail.org)
29 Mar 2003 21:00:24 +0100
On Sat, 2003-03-29 at 19:29, john@grabjohn.com wrote:
> > this patch un-complicates a small piece of code of the dev/pts
> > filesystem and decreases the size of the object code by 8 bytes
> > for my build. Yay! :)
>
> > - err = PTR_ERR(devpts_mnt);
> > - if (!IS_ERR(devpts_mnt))
> > - err = 0;
> > + if (IS_ERR(devpts_mnt))
> > + err = PTR_ERR(devpts_mnt);
>
> Why not use
>
> err = (IS_ERR(devpts_mnt) ? err = 0 : PTR_ERR(devpts_mnt));
Ugg! That's really ugly! ;-)
________________________________________________________________________
Felipe Alfaro Solana
Linux Registered User #287198
http://counter.li.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/