Re: [PATCH] (2.5.66-mm2) War on warnings

Martin J. Bligh (mbligh@aracnet.com)
Tue, 01 Apr 2003 11:36:29 -0800


> diff -Nur --exclude-from=/usr/src/.dontdiff linux-2.5.66-vanilla/drivers/char/drm/r128_cce.c linux-2.5.66-warnings/drivers/char/drm/r128_cce.c
> --- linux-2.5.66-vanilla/drivers/char/drm/r128_cce.c Mon Mar 24 14:00:07 2003
> +++ linux-2.5.66-warnings/drivers/char/drm/r128_cce.c Mon Mar 31 11:55:16 2003
> @@ -352,7 +352,7 @@
> entry->busaddr[page_ofs]);
> DRM_DEBUG( "ring rptr: offset=0x%08x handle=0x%08lx\n",
> entry->busaddr[page_ofs],
> - entry->handle + tmp_ofs );
> + (unsigned long)entry->handle + tmp_ofs );
> }
>
> /* Set watermark control */

These sort of things really need to be typecast to u64 if that's
the dma_addr_t printk problem ... otherwise you silently lose data,
which is most confusing.

linux-2.5.66-vanilla/drivers/scsi/scsi_sysfs.c linux-2.5.66-warnings/drivers/scsi/scsi_sysfs.c
> --- linux-2.5.66-vanilla/drivers/scsi/scsi_sysfs.c Mon Mar 24 14:00:08 2003
> +++ linux-2.5.66-warnings/drivers/scsi/scsi_sysfs.c Mon Mar 31 11:56:02 2003
> @@ -272,14 +272,17 @@
> return 0;
> }
>
> +void scsi_rescan_device(struct scsi_device *);
> static ssize_t
> store_rescan_field (struct device *dev, const char *buf, size_t count)
> {
> int ret = ENODEV;
> struct scsi_device *sdev;
> sdev = to_scsi_device(dev);
> - if (sdev)
> - ret = scsi_rescan_device(sdev);
> + if (sdev){
> + ret = 0;
> + scsi_rescan_device(sdev);
> + }
> return ret;
> }

That's pretty much what I did, but apparently Christoph had a better fix
posted to linux-scsi somewhere. I lost it though ...

M.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/