Re: [PATCH] only use 48-bit lba when necessary

John Bradford (root@81-2-122-30.bradfords.org.uk)
Fri, 4 Apr 2003 18:06:34 +0100 (BST)


> > Reason is that:
> >
> > if (expr)
> > var = true;
> > else
> > var = false;
> >
> > is always a bad construct.
> >
> > var = expr;
> >
> > is a better construct to express that meaning.
> >
> > And yes, your is a variation of the same theme:
> >
> > var = false;
> > if (expr)
> > var = true;
>
> Yes, but mine is more readable. IMO of course, that's the way it is with
> styles.

if (!expr || expr) var=(!expr ? !expr : expr);

:-)

John.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/