Re: PATCH: jiffies is UL

Andrew Morton (akpm@digeo.com)
Mon, 7 Apr 2003 17:40:27 -0700


Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux-2.5.67/include/linux/time.h linux-2.5.67-ac1/include/linux/time.h
> --- linux-2.5.67/include/linux/time.h 2003-03-06 17:04:37.000000000 +0000
> +++ linux-2.5.67-ac1/include/linux/time.h 2003-03-07 14:57:13.000000000 +0000
> @@ -31,7 +31,7 @@
> * Have the 32 bit jiffies value wrap 5 minutes after boot
> * so jiffies wrap bugs show up earlier.
> */
> -#define INITIAL_JIFFIES ((unsigned int) (-300*HZ))
> +#define INITIAL_JIFFIES ((unsigned long) (-300*HZ))
>

No, this is deliberate. It triggers a wrap from 0x00000000ffffffff to
0x0000000100000000 after 5 minutes uptime on 64-bit machines, which has found
bugs.

The fix is to add a comment, so this patch stops coming out ;)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/