> D: Jeff points out that SET_MODULE_OWNER is really only for struct
> D: net_device, so move it from module.h to netdevice.h and fix up
> D: areas which were confused about it (renaming would be nice, but
> D: too invasive).
Rusty, this is amazingly disingenuous.
Never did I say SET_MODULE_OWNER was only for struct net_device.
I even pointed out specifically that it IS NOT tied to a specific structure:
> no, SET_MODULE_OWNER is quite intentionally independent of the struct. It only requires a consisnent naming in the source, between structures that may use the macro.
> That's a feature.
Why don't you just let the maintainers apply the driver "cleanups" if
they wish, or do not wish, like DaveM did. Only when that is
accomplished is it reasonable to consider moving SET_MODULE_OWNER -- and
only then if other people do not need it's obvious utility.
I would personally rather the macro lived on as a part of the module
API. Think of it as part of maintaining friendly hardware vendor
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to firstname.lastname@example.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/