Re: proc_misc.c bug

Randy.Dunlap (rddunlap@osdl.org)
Thu, 10 Apr 2003 15:49:02 -0700


On 10 Apr 2003 22:44:17 +0100 Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

| On Thu, 2003-04-10 at 23:02, David Mosberger wrote:
| > The workaround below is to allocate 4KB per 8 CPUs. Not really a
| > solution, but the fundamental problem is that /proc/interrupts
| > shouldn't use a fixed buffer size in the first place. I suppose
| > another solution would be to use vmalloc() instead. It all feels like
| > bandaids though.
|
| How about switching to Al's seqfile interface ?

It's already using it, but it uses the simple/single version of it,
which doesn't automagically extend the output buffer area when
it's full, so a max size buffer has to be allocated for it
up front.

I'll look at changing it unless somebody beats me (to it :).

--
~Randy   ['tangent' is not a verb...unless you believe that
          "in English any noun can be verbed."]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/