Re: [PATCH] reducing overheads in fget/fput

viro@parcelfarce.linux.theplanet.co.uk
Mon, 28 Apr 2003 20:32:28 +0100

On Mon, Apr 28, 2003 at 10:22:40PM +0530, Dipankar Sarma wrote:
> Does this approach make sense ? Or am I missing some big gotcha
> somewhere ? Oh, btw the patch survives LTP.

You are. Have a process share file table at the time of call and
have its sibling die in the middle. Oops - condition that had
been true at time of fget_light() (->files->count > 1) is false
at the time we fput_light(). Have fun - we had just leaked a
reference to struct file.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/