--=_courier-4784-1051704586-0001-2
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Tue, 2003-04-01 at 21:30, Linux Kernel Mailing List wrote:
> # This patch includes the following deltas:
> # ChangeSet 1.1044 -> 1.1045=20
> # drivers/hotplug/ibmphp_ebda.c 1.6 -> 1.7 =20
> #
>=20
> ibmphp_ebda.c | 25 ++++++++++++++++++++++---
> 1 files changed, 22 insertions(+), 3 deletions(-)
>=20
>=20
> diff -Nru a/drivers/hotplug/ibmphp_ebda.c b/drivers/hotplug/ibmphp_ebda.c
> --- a/drivers/hotplug/ibmphp_ebda.c Tue Apr 1 13:05:41 2003
> +++ b/drivers/hotplug/ibmphp_ebda.c Tue Apr 1 13:05:41 2003
> @@ -608,13 +608,20 @@
> return str;
> default: =09
> //2 digits number
> + str1 =3D (char *) kmalloc (2, GFP_KERNEL);
> + if (!str1) {
> + break;
> + }
> + memset (str, 0, 3);
> *str1 =3D (char)(bit + 48);
> strncpy (str, str1, 1);
> memset (str1, 0, 3);
> *str1 =3D (char)((var % 10) + 48);
> strcat (str, str1);
> + kfree(str1);
> return str;
> - }=09
> + }
> + kfree(str);
> return NULL;=09
> }
ehm I'd suggest backing out this change. Not only do we have snprintf
nowadays, it also corrupts memory by memsetting stuff bigger than it
allocated....
--=_courier-4784-1051704586-0001-2
Content-Type: application/pgp-signature; name="signature.asc"
Content-Transfer-Encoding: 7bit
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQA+r7xrxULwo51rQBIRAn7MAKCEXnuqzI0IjAsI7Upu//I5Feh6lQCffd2f
LdWO6SYLC9gX64sm1aMQ8Cc=
=UhTu
-----END PGP SIGNATURE-----
--=_courier-4784-1051704586-0001-2--