[PATCH] Linux 2.5.68 - Fix module_put after return in drivers/net/wan/n2.c

[Gabriel Devenyi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This patch applies to 2.5.68. It is a bug listed at kbugs.org. module_put is never executed because it is after return.

Please CC me with any discussion.
- -- 
Building the Future,
Gabriel Devenyi
[e-mail]

- ---FILE---

- --- linux-2.5.68/drivers/net/wan/n2.c	2003-04-19 22:48:55.000000000 -0400
+++ linux-2.5.68-changed/drivers/net/wan/n2.c	2003-05-01 15:05:36.000000000 -0400
@@ -223,8 +223,8 @@
 
 	int result = hdlc_open(hdlc);
 	if (result) {
- -		return result;
 		module_put(THIS_MODULE);
+		return result;
 	}
 
 	mcr &= port->phy_node ? ~DTR_PORT1 : ~DTR_PORT0; /* set DTR ON */

- ---ENDFILE---
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+sXxm7I5UBdiZaF4RAu8kAJ0RKpz8xwzNovBJIgD/vd4f4hEAzQCeNKpI
USAyeWl6lmsVqOPEzV/r1tI=
=rplC
-----END PGP SIGNATURE-----