Re: [PATCH] Fix NULL handler for compat_ioctl

[Andrew Morton]

Ben Collins <[e-mail]> wrote:
>
> > - sys_ioctl takes three args, but this vector is going to be called with
> >   four.  That's making assumptions about arg passing conventions which may
> >   not be true.
> > 
> > - sys_ioctl() is asmlinkage, but the caller of this vector doesn't know
> >   that.  Arguments may get put in the wrong place.
> 
> Out of all the register_ioctl32_conversion functions that were
> consolidated with this patch, only s390 and x86_64 did not already use
> this same convention. linux/ioctl32.h already documents (and has always
> been that way) this feature.

Yup. I'm not surprised that it works.  But ick.

> Maybe you feel better about this patch instead?

Infinitely ;)