Re: [PATCH] Fix NULL handler for compat_ioctl
Andrew Morton (firstname.lastname@example.org)
Wed, 30 Apr 2003 20:40:46 -0700
Ben Collins <email@example.com> wrote:
> > - sys_ioctl takes three args, but this vector is going to be called with
> > four. That's making assumptions about arg passing conventions which may
> > not be true.
> > - sys_ioctl() is asmlinkage, but the caller of this vector doesn't know
> > that. Arguments may get put in the wrong place.
> Out of all the register_ioctl32_conversion functions that were
> consolidated with this patch, only s390 and x86_64 did not already use
> this same convention. linux/ioctl32.h already documents (and has always
> been that way) this feature.
Yup. I'm not surprised that it works. But ick.
> Maybe you feel better about this patch instead?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to firstname.lastname@example.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/