> One suggestion: don't make it a CONFIG_*. Recompiling a kernel
> to change things like that is not good. Make it an ioctl that
> can be configured at runtime.
>
that's why I would prefer a LKM instead of a kernel patch. If you know a
clean way to save/restore irq-handlers please let me know. That would
also allow to make it portable to other platforms like Apple iBook or
notebooks with other than PS/2 trackpads.
Implementing an ioctl() is a nice idea too. But why not have it
configurable via the /proc interface? If you use ioctl() you still need
to write a userspace program. Ok, that's not difficult, but I think it's
more comfortable if you can simply use
#/etc/rc.d/trackpad, set trackpad delay time
echo "trackpad delay=2000" > /proc/something
#/etc/hotplug??? external mouse is just plugged in, disable trackpad
echo "trackpad disable=1" > /proc/something
#/etc/hotplug??? external mouse is just revmoved, re-enable trackpad
echo "trackpad disable=0" > /proc/something
> Another one: the disable_trackpad_timer_while_typing variable is not
> really needed. You can manage all state by checking the timer with
> timer_pending()
>
yes ok, so I can save one variable. But I would than have to make the
enable_trackpad_timer a static global var. That's not really bad, but I
feel that "complex datastructures" better hidden in a function, - but
it's only a "feeling"
-Hans
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/