Re: [PATCH] new kconfig goodies

Tomas Szepe (szepe@pinerecords.com)
Mon, 12 May 2003 18:00:29 +0200


> [davej@codemonkey.org.uk]
>
> On Mon, May 12, 2003 at 03:39:11PM +0200, Roman Zippel wrote:
>
> > config AGP
> > tristate "/dev/agpgart (AGP Support)" if !GART_IOMMU
> > default y if GART_IOMMU
> >
> > this can be changed into:
> >
> > config AGP
> > tristate "/dev/agpgart (AGP Support)"
> >
> > config GART_IOMMU
> > bool "IOMMU support"
> > enable AGP
> >
> > This will cause AGP to be selected if GART_IOMMU is selected.
>
> Looks good. However, will this still offer the CONFIG_AGP tristate
> in the menu? If IOMMU is on, there must be no way to switch off
> the agpgart support on which it depends.

Also, will the config system let the user know that their having
enabled a certain option has affected other options (possibly in
different submenus)? As things work now, there's no way to tell
if an option has been switched on "by dependency," so in the above
example, in switching GART_IOMMU off after its switching on has
enabled AGP, the system won't know to disable AGP again. I'm not
convinced this is a nice feature in fact. :) Maybe we just need
something like grayed-out entries with a comment, for instance:

/* [ ] IOMMU support (needs "/dev/agpgard (AGP Support)") */

-- 
Tomas Szepe <szepe@pinerecords.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/