Re: [PATCH] fix net/rxrpc/proc.c

David Howells (dhowells@warthog.cambridge.redhat.com)
Tue, 13 May 2003 10:25:04 +0100


> > Thanks, sorry, I should have Cc:'d you in the first place, my apology.
> > Seems like the rxrpc_proc_calls_fops should get an owner as well?
> > (relative to the last patch)
>
> Should all file_operations tables associated with this be "owned" in this
> manner?

Hmmm... actually, looking at the code, it ought to be unnecessary as the proc
entries are "owned", eg:

int rxrpc_proc_init(void)
{
struct proc_dir_entry *p;

proc_rxrpc = proc_mkdir("rxrpc",proc_net);
if (!proc_rxrpc)
goto error;
proc_rxrpc->owner = THIS_MODULE;

...
}

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/