Re: 2.5.69-mm5: reverting i8259-shutdown.patch

Patrick Mochel (mochel@osdl.org)
Thu, 15 May 2003 10:35:55 -0700 (PDT)


> OK, I've changed "#undef DEBUG" to "#define DEBUG" in
> drivers/base/power.c, but during shutdown, I can see no extra debug
> messages. What am I doing wrong?

Nothing. No one has shutdown methods in their drivers. This patch should
give you a little more info. For me, it says the i8259 is getting shutdown
very early in the process, which surely can't be good..

-pat

===== drivers/base/power.c 1.18 vs edited =====
--- 1.18/drivers/base/power.c Mon Jan 6 09:56:05 2003
+++ edited/drivers/base/power.c Thu May 15 10:30:25 2003
@@ -8,7 +8,7 @@
*
*/

-#undef DEBUG
+#define DEBUG

#include <linux/device.h>
#include <linux/module.h>
@@ -88,10 +88,12 @@
down_write(&devices_subsys.rwsem);
list_for_each(entry,&devices_subsys.kset.list) {
struct device * dev = to_dev(entry);
+ pr_debug("shutting down %s: ",dev->name);
if (dev->driver && dev->driver->shutdown) {
- pr_debug("shutting down %s\n",dev->name);
+ pr_debug("Ok\n");
dev->driver->shutdown(dev);
- }
+ } else
+ pr_debug("Ignored.\n");
}
up_write(&devices_subsys.rwsem);
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/