Re: [2.5 patch] let USB_GADGET depend on USB

David Brownell (david-b@pacbell.net)
Sun, 01 Jun 2003 07:18:54 -0700


This is a MIME-formatted message. If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_courier-30456-1054477283-0001-2
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Adrian Bunk wrote:
> On Sat, May 31, 2003 at 04:39:28PM -0700, David Brownell wrote:
>
>>Adrian Bunk wrote:
>>
>>>USB_GADGET is still selectable even with USB disabled. It seems the
>>>following is intended:
>>
>>This is wrong.
>>
>>CONFIG_USB has always represented the master/host side ... while
>>CONFIG_USB_GADGET represents just the slave/gadget side.
>>
>>The two are completely independent. Hardware that supports
>>one will typically _not_ support the other. And systems
>>that support [only] the slave/gadget side will have no use at all
>>for the 100KB+ of "usbcore".
>>...
>
>
> Well, CONFIG_USB_GADGET without CONFIG_USB gives me the following link
> error in 2.5.70-mm3:

As I had already said (in response to your email that reported
that problem), the fix is to revert the recent changeset that
links gadget code twice. Here's a patch that undoes it.

- Dave

--=_courier-30456-1054477283-0001-2
Content-Type: text/plain; name="link.patch"; charset=iso-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="link.patch"

--- a/drivers/usb/Makefile Sun Jun 1 07:14:50 2003
+++ b/drivers/usb/Makefile Sun Jun 1 07:14:50 2003
@@ -59,6 +59,3 @@
obj-$(CONFIG_USB_TIGL) += misc/
obj-$(CONFIG_USB_USS720) += misc/

-obj-$(CONFIG_USB_NET2280) += gadget/
-obj-$(CONFIG_USB_ZERO) += gadget/
-obj-$(CONFIG_USB_ETH) += gadget/

--=_courier-30456-1054477283-0001-2--