Re: [PATCH] And yet more PCI fixes for 2.5.70

[Christoph Hellwig]

On Wed, Jun 11, 2003 at 01:37:37PM +0100, Alan Cox wrote:
> On Mer, 2003-06-11 at 01:11, Greg KH wrote:
> >  			/* user supplied value */
> >  			system_bus_speed = idebus_parameter;
> > -		} else if (pci_present()) {
> > +		} else if (pci_find_device(PCI_ANY_ID, PCI_ANY_ID, NULL) != NULL) {
> 
> That is just gross. pci_present() is far more readable even if you make
> it an inline in pci.h that is pci_find_device(PCI_ANY_ID, PCI_ANY_ID,
> NULL)

The whole surround code seems rather bogus.  Most of the drivers actually
using this are PCI ones so we _know_ pci is present when this gets
called.  And for the few other it should probably be a per-driver
thing instead, i.e. if the device hangs of a specific pci bus use
the ide busspeed, else not.