Re: 2.5.70-bk16: nfs crash

[Dipankar Sarma]

On Thu, Jun 12, 2003 at 08:49:53AM -0700, Linus Torvalds wrote:
> On Thu, 12 Jun 2003, Dipankar Sarma wrote:
> > 
> > hlist poison patch is broken. list_del_rcu() and hlist_del_rcu() 
> > *must not* re-initialize the pointers. Maneesh submitted a patch
> > earlier today that corrects this -
> 
> Sorry, but you're wrong.
> 
> If you depend on not re-initializing the pointers, you should not use the 
> "xxx_del()" function, and you should document it.

Right. That is why they are list_del_rcu() and hlist_del_rcu().
The comments for list_del_rcu() clearly say that pointers
are not re-initialized.

> 
> This is that the __xxx_del() functions are there for - they won't do the
> poisoning. The regular delete functions have historically always poisoned
> the pointers - it was only removed a few months ago by Andrew.

Poisoning xxx_del() functions is ok. That should be done.

Thanks
Dipankar