[patch][2.5] speedstep_detect_speed might not reenable interrupts

Samuel Thibault (Samuel.Thibault@ens-lyon.fr)
Sat, 14 Jun 2003 02:35:39 -0400


hi,

local_irq_save() is called at the beginning of speedstep_detect_speeds,
but local_irq_restore() is not called on I/O errors.

--- linux-2.5.70-bk12/arch/i386/kernel/cpu/cpufreq/speedstep.c 2003-05-26 21:00:20.000000000 -0400
+++ linux-2.5.70-bk12-perso/arch/i386/kernel/cpu/cpufreq/speedstep.c 2003-06-14 02:23:34.000000000 -0400
@@ -538,8 +538,10 @@
for (i=0; i<2; i++) {
/* read the current state */
result = speedstep_get_state(&state);
- if (result)
+ if (result) {
+ local_irq_restore(flags);
return result;
+ }

/* save the correct value, and switch to other */
if (state == SPEEDSTEP_LOW) {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/