[PATCH] DM: 2.5.71: dm-ioctl.c: Unregister with devfs before renaming the device

Kevin Corry (kevcorry@us.ibm.com)
Mon, 16 Jun 2003 15:53:56 -0500


Unregister the previous name from devfs before renaming the device.

DM originally stored a devfs handle in the hash-cell, and performed the
unregister based on that handle. These devfs handles have since been removed,
and devices are registered and unregistered simply based on their names. So
the device now needs to be unregistered before we lose the name.

See the following BK change for more details:
http://linux.bkbits.net:8080/linux-2.5/diffs/drivers/md/dm-ioctl.c@1.6?nav=index.html|src/|src/drivers|src/drivers/md|hist/drivers/md/dm-ioctl.c

--- linux-2.5.71a/drivers/md/dm-ioctl.c 16 Jun 2003 18:14:56 -0000
+++ linux-2.5.71b/drivers/md/dm-ioctl.c 16 Jun 2003 20:20:05 -0000
@@ -297,13 +297,14 @@
/*
* rename and move the name cell.
*/
+ unregister_with_devfs(hc);
+
list_del(&hc->name_list);
old_name = hc->name;
hc->name = new_name;
list_add(&hc->name_list, _name_buckets + hash_str(new_name));

/* rename the device node in devfs */
- unregister_with_devfs(hc);
register_with_devfs(hc);

up_write(&_hash_lock);

-- 
Kevin Corry
kevcorry@us.ibm.com
http://evms.sourceforge.net/

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/