Re: 2.5: wrong CONFIG_SND_SEQUENCER logic in several drivers

Jaroslav Kysela (perex@suse.cz)
Sat, 21 Jun 2003 09:53:02 +0200 (CEST)


On Sat, 21 Jun 2003, Adrian Bunk wrote:

> @Jaroslav:
> Several drivers have a wrong logic for CONFIG_SND_SEQUENCER. The correct
> solution is something like the following:
>
> --- sound/pci/emu10k1/emu10k1.c.old 2003-06-21 03:02:04.000000000 +0200
> +++ sound/pci/emu10k1/emu10k1.c 2003-06-21 03:02:31.000000000 +0200
> @@ -35,7 +35,7 @@
> MODULE_DEVICES("{{Creative Labs,SB Live!/PCI512/E-mu APS},"
> "{Creative Labs,SB Audigy}}");
>
> -#if defined(CONFIG_SND_SEQUENCER) || defined(CONFIG_SND_SEQUENCER_MODULE)
> +#if defined(CONFIG_SND_SEQUENCER) || (defined (MODULE) && defined(CONFIG_SND_SEQUENCER_MODULE))
> #define ENABLE_SYNTH
> #include <sound/emu10k1_synth.h>
> #endif
>
> If you comfirm this is correct I'll send a fix for all affected drivers.

Yes, it's correct. I fixed our code. The fix will be in the next ALSA
2.5 update. Thanks.

Jaroslav

-----
Jaroslav Kysela <perex@suse.cz>
Linux Kernel Sound Maintainer
ALSA Project, SuSE Labs

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/