Re: [patch] SiS IRQ router 96x detection (2.5.69) ...

[Davide Libenzi]

On Sun, 22 Jun 2003, Thomas Winischhofer wrote:

> Davide Libenzi wrote:
> > I have to admit that I was tempted to let this go through by simply
> > ignoring you.
>
> Ouch, this hurts. The lawyer in me just told me that this is no proper
> way to argue. And he means both sides. I think he's right.
>
> Davide, calm down and take a deep breath. Better? :)

I am calm :) I do respect Alan but sometime he just says unbeliveable
things.

> Alan probably receives thousands of mails every day and he therefore
> tends to make it somewhat very short sometimes. Be happy that he even
> aswered at all, right?

Not really. Like you were pointing out, this was not :

Subject: [patch] Improving VM performance by 1.02% using bozo-hashes ...

The new SiS chipset using the 96x SB will make the kernel to puke in the
face of the poor user that will try to install Linux on the machine that
is employing it. The whole USB subsystem will remain quite because of this.
Now, the "was so ugly to have no words" was basically because I added
explicit initialization to NULL of the new "detect" function pointer. This
was the note that Alan posted to lkml. I *very personally* do want full
structure initialization when using the old field-order-based method. It
is sure easier for me to add a single "detect" explicit initialization at
the end of the sequence, but it'll become generally a mess if the
structure will grow in number of fields. Think about the old INIT_TASK
macro. I also proposed to rewrite the damn structure array initialization
using the C99 syntax, that way better suite the sparse field
initialization. No answer though. Now, it's not the playing with the PCI
IRQ routing does excite me a lot and I did it simply because my machine
didn't work. I did spend a few hours on the patch and I was willing to
spend another one to see the kernel fixed. But if he does not care, why
should I ?

- Davide