Re: [patch] kprobes for 2.5.73 with single-stepping out-of-line

Andi Kleen (ak@suse.de)
24 Jun 2003 18:01:09 +0200


"Vamsi Krishna S ." <vamsi@in.ibm.com> writes:

> +static struct kprobe *current_kprobe;

This global variable is quite unclean. It looks like it is for passing
function arguments around. Why is it needed?

> +#define KPROBE_HASH_BITS 6
> +#define KPROBE_TABLE_SIZE (1 << KPROBE_HASH_BITS)
> +
> +static struct list_head kprobe_table[KPROBE_TABLE_SIZE];

Use hlists?

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/