Re: [RFC][PATCH] nbd driver for 2.5+: fix locking issues with ioctl

Paul Clements (kernel@steeleye.com)
Wed, 25 Jun 2003 13:48:16 -0400 (EDT)


Lou,

a few comments on the patch...

On Wed, 25 Jun 2003, Lou Langholtz wrote:
> Please review and comment...
>
> This is the sixth patch to the NBD driver and it fixes a variety of
> outstanding locking issues with the ioctl user interface. This patch

This patch introduces a locking hierarchy between the lo->tx_lock and
lo->queue_lock. The existing driver does not have this limitation.
I would feel a lot better about this patch if you were to recode it
to avoid this.

Also, I noticed that you've removed the forcible shutdown of the
socket at the end of NBD_DO_IT. Was there a particular reason for
that?

> ... the new NBD_DO_IT style interface
> could be introduced instead as another ioctl completely and these 3
> ioctls could be maintained for backward compatibility for a while
> longer.

It would be really nice if the driver remained (as much as
possible) compatible with the 2.4 version...unless you have
a really good reason to break things... :)

--
Paul

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/